-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Update FW upgrade script to use 'mlxfwmanager -d' option for specifying MST device in FW burn operation #6541
Conversation
… FW burn operation." This reverts commit 088c240.
@liorghub was there any problem to choose MST device without this change? |
The path to MST device is not the same in all systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a section how it was tested for both sonic to sonic upgrade (via the different reboots)
Added. |
@sujinmkang Appreciate your review. |
5ea2015
to
ca30193
Compare
ca30193
to
37f96ec
Compare
37f96ec
to
5ebb9ca
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@abdosi suggest to include in 201911. Please approve and add the relevant label. |
…or specifying MST device in FW burn operation (#6541) **- Why I did it** Reduce the time it takes for the ASIC FW burn as part of the automatic FW upgrade procedure. **- How I did it** Add -d option to mlxfwmanager tool to use the faster MST device and not the default one which is not the fastest one. **- How to verify it** I manually changed ASIC FW followed by reboot command in order for FW upgrade to take place on deinit. I manually changed ASIC FW followed by hard reset in order for FW upgrade to take place on init. Signed-off-by: liora <liora@nvidia.com>
- Why I did it
Reduce the time it takes for the ASIC FW burn as part of the automatic FW upgrade procedure.
- How I did it
Add -d option to mlxfwmanager tool to use the faster MST device and not the default one which is not the fastest one.
- How to verify it
I manually changed ASIC FW followed by reboot command in order for FW upgrade to take place on deinit.
I manually changed ASIC FW followed by hard reset in order for FW upgrade to take place on init.
- Which release branch to backport (provide reason below if selected)